refactor(signature_collector): Remove base_hash
#437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the base_hash field from the signature collector system, as the comment indicating it was needed for different signing roots was incorrect. The actual attestation data is the same for all validators, so the signing root can be used directly instead of maintaining a separate base hash.
- Removed
base_hashparameter fromSignatureRequester::Committeevariant and all related function calls - Renamed
ValidatorSigningDatatoSigningDatato reflect its broader usage beyond just validator signing - Updated all references to use the signing root directly instead of the base hash for committee signature tracking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| anchor/validator_store/src/lib.rs | Removed base_hash parameter from collect_signature method and all its call sites, replaced logic to use Role::Committee check instead |
| anchor/signature_collector/src/lib.rs | Removed base_hash field from SignatureRequester::Committee, renamed ValidatorSigningData to SigningData, updated committee signature tracking to use signing root |
Comments suppressed due to low confidence (1)
anchor/validator_store/src/lib.rs:974
- This line computes
data_hashbut it's no longer used anywhere in the code after removing thebase_hashparameter. This creates unused code that should be removed.
};
diegomrsantos
approved these changes
Jul 24, 2025
dknopik
added
ready-for-merge
and removed
ready-for-review
17 tasks
dknopik
added a commit
to dknopik/anchor
that referenced
this pull request
Aug 11, 2025
diegomrsantos
pushed a commit
to diegomrsantos/anchor
that referenced
this pull request
Sep 17, 2025
diegomrsantos
pushed a commit
to diegomrsantos/anchor
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the comment:
This is example incorrect. Only the actual attestation data is signed - which is the same for all validators. Therefore there is no reason for this
base_hashfield to exist - we can simply use the signing root for the same purpose.Additional Info
Also renamed
ValidatorSigningDatatoSigningDatanow that we also use the data within for committee signature tracking purposes.